From 8f970072e83c3c4f7e79835af9840cb02fd57f22 Mon Sep 17 00:00:00 2001 From: Julien Bisconti Date: Mon, 13 Apr 2020 17:49:23 +0200 Subject: [PATCH 1/4] Fix github action path --- .github/{workflow => workflows}/pull_request.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{workflow => workflows}/pull_request.yml (100%) diff --git a/.github/workflow/pull_request.yml b/.github/workflows/pull_request.yml similarity index 100% rename from .github/workflow/pull_request.yml rename to .github/workflows/pull_request.yml From fd49c3a59de3a82b2c37e107e638d7bf045e15a4 Mon Sep 17 00:00:00 2001 From: Julien Bisconti Date: Mon, 13 Apr 2020 17:52:26 +0200 Subject: [PATCH 2/4] Setup github token --- .github/workflows/pull_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 09b2a1f..4af5dac 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -26,5 +26,5 @@ jobs: if: steps.cache.outputs.cache-hit != 'true' run: npm ci --ignore-scripts --no-audit --no-progress --prefer-offline - run: npm run test - with: + env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 0b371c8aca83505017a7434b9b3516dbd5c88776 Mon Sep 17 00:00:00 2001 From: Julien Bisconti Date: Mon, 13 Apr 2020 17:54:25 +0200 Subject: [PATCH 3/4] Display env var nicely --- pull_request.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pull_request.js b/pull_request.js index 351f5de..443949c 100644 --- a/pull_request.js +++ b/pull_request.js @@ -6,7 +6,7 @@ function envvar_undefined(variable_name) { throw new Error(`${variable_name} must be defined`); } console.log({ - DEBUG: process.env.DEBUG, + DEBUG: process.env.DEBUG || false, }); const README = 'README.md'; From 65115d96c9389264b293bcbfee5a82317751331b Mon Sep 17 00:00:00 2001 From: Julien Bisconti Date: Mon, 13 Apr 2020 17:59:20 +0200 Subject: [PATCH 4/4] Dont skip cache, apparently --- .github/workflows/pull_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 4af5dac..145a333 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -23,7 +23,7 @@ jobs: ${{ runner.os }}-node- - name: Install Dependencies - if: steps.cache.outputs.cache-hit != 'true' + # if: steps.cache.outputs.cache-hit != 'true' run: npm ci --ignore-scripts --no-audit --no-progress --prefer-offline - run: npm run test env: