personal_interest_mirrors/nebula
1
0
Fork 0
mirror of https://github.com/slackhq/nebula.git synced 2026-07-02 11:30:29 +02:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

wireshark: fix Lua 5.4 bitwise operation (#1776)
smoke-extra / Run windows smoke test (push) Waiting to run
Details
Build and test / Test macos (push) Waiting to run
Details
Build and test / Test windows (push) Waiting to run
Details
Build and test / CI status (push) Blocked by required conditions
Details
smoke-extra / freebsd-amd64 (push) Failing after 16s
Details
smoke-extra / linux-amd64-ipv6disable (push) Failing after 16s
Details
smoke-extra / netbsd-amd64 (push) Failing after 14s
Details
smoke-extra / openbsd-amd64 (push) Failing after 14s
Details
smoke-extra / linux-386 (push) Failing after 14s
Details
smoke / Run multi node smoke test (push) Failing after 1m27s
Details
Build and test / Static checks (push) Successful in 1m46s
Details
Build and test / Test linux (push) Failing after 1m41s
Details
Build and test / Test linux-boringcrypto (push) Failing after 2m49s
Details
Build and test / Test linux-pkcs11 (push) Failing after 2m49s
Details
Build and test / Cross-build linux-arm (push) Successful in 3m1s
Details
Build and test / Cross-build linux-mips (push) Successful in 3m41s
Details
Build and test / Cross-build linux-other (push) Successful in 3m4s
Details
Build and test / Cross-build windows (push) Successful in 1m1s
Details
Build and test / Cross-build freebsd (push) Successful in 1m32s
Details
Build and test / Cross-build netbsd (push) Successful in 1m33s
Details
Build and test / Cross-build openbsd (push) Successful in 1m31s
Details
Build and test / Cross-build mobile (push) Successful in 3m12s
Details

Browse Source 
The Nebula Wireshark dissector uses bit32.band() when parsing the
Nebula packet type. On Wireshark builds using Lua 5.4, bit32 is not
available, which causes dissection to fail with:

Lua Error: nebula.lua:65: attempt to index a nil value (global 'bit32')

Wireshark bundles Lua BitOp and exposes it globally as bit for Lua
dissectors. This is the documented API for maximum backwards
compatibility across supported Lua versions.

Use bit.band() instead of bit32.band().
This commit is contained in:
zorvios
2026-07-01 22:12:14 +01:00
committed by GitHub
parent 58ab7250f5
commit 02471b4121
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dist/wireshark/nebula.lua
Vendored
+1 -1
View File
@@ -62,7 +62,7 @@ function nebula.dissector(tvbuf, pktinfo, root)
tree:add(pf_version, tvbuf:range(0,1)) tree:add(pf_version, tvbuf:range(0,1))
local type = tree:add(pf_type, tvbuf:range(0,1)) local type = tree:add(pf_type, tvbuf:range(0,1))
local nebula_type = bit32.band(tvbuf:range(0,1):uint(), 0x0F) local nebula_type = bit.band(tvbuf:range(0,1):uint(), 0x0F)
if nebula_type == 0 then if nebula_type == 0 then
local stage = tvbuf(8,8):uint64() local stage = tvbuf(8,8):uint64()
tree:add(pf_subtype_handshake, tvbuf:range(1,1)) tree:add(pf_subtype_handshake, tvbuf:range(1,1))