mirror of
https://github.com/slackhq/nebula.git
synced 2026-11-17 01:16:52 +01:00
Remove staged receive stage timing metrics
This commit is contained in:
1 parent
4d6f757d1f
commit
8f34981764
2 files changed
+9
-49
No files matched your search
@@ -1,13 +1,10 @@
|
||||
package nebula
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"log/slog"
|
||||
"runtime"
|
||||
"sync"
|
||||
"time"
|
||||
|
||||
"github.com/rcrowley/go-metrics"
|
||||
"github.com/slackhq/nebula/config"
|
||||
)
|
||||
|
||||
@@ -19,10 +16,6 @@ import (
|
||||
//
|
||||
// Metrics are registered only for active pipelines. flow.rx.batches counts batches handed to the writer and
|
||||
// flow.rx.inline those an idle listener handled itself; their rates show whether staging is used.
|
||||
// flow.stage.<stage>.q<queue>.busy_ns locates the limiting stage: rx_read, rx_decrypt or rx_write. Take rates; 1e9
|
||||
// ns/s fills a serial stage. These are elapsed times that exclude read syscalls and downstream waits; descheduling
|
||||
// inflates them and worker times add up across the pool. Small batches sent to the writer include decryption in
|
||||
// writer time.
|
||||
|
||||
// stagedConfig is tun.staged. workers is per routine; zero keeps receive inline.
|
||||
type stagedConfig struct {
|
||||
@@ -57,15 +50,13 @@ type flowPool struct {
|
||||
wg sync.WaitGroup
|
||||
}
|
||||
|
||||
func newFlowPool(workers, queueLen int, busy metrics.Counter) *flowPool {
|
||||
func newFlowPool(workers, queueLen int) *flowPool {
|
||||
p := &flowPool{jobs: make(chan flowJob, queueLen)}
|
||||
for range workers {
|
||||
p.wg.Go(func() {
|
||||
nb := make([]byte, 12)
|
||||
for job := range p.jobs {
|
||||
t := time.Now()
|
||||
job.run(nb)
|
||||
busy.Inc(int64(time.Since(t)))
|
||||
}
|
||||
})
|
||||
}
|
||||
@@ -73,8 +64,3 @@ func newFlowPool(workers, queueLen int, busy metrics.Counter) *flowPool {
|
||||
}
|
||||
|
||||
func (p *flowPool) close() { close(p.jobs); p.wg.Wait() }
|
||||
|
||||
// stageBusy is the busy time counter of one stage of routine q.
|
||||
func stageBusy(stage string, q int) metrics.Counter {
|
||||
return metrics.GetOrRegisterCounter(fmt.Sprintf("flow.stage.%s.q%d.busy_ns", stage, q), nil)
|
||||
}
|
||||
Reference in new issue
Block a user