From e5e449cb1978f4bc76c95247cff6044690f1f5f4 Mon Sep 17 00:00:00 2001 From: Wade Simmons Date: Mon, 4 Aug 2025 15:48:14 -0400 Subject: [PATCH] cleanup --- bits_test.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/bits_test.go b/bits_test.go index 0939f8c..ef32ba6 100644 --- a/bits_test.go +++ b/bits_test.go @@ -212,8 +212,11 @@ func TestBitsLostCounter(t *testing.T) { assert.Equal(t, int64(36), b.lostCounter.Count()) assert.Equal(t, int64(0), b.dupeCounter.Count()) assert.Equal(t, int64(0), b.outOfWindowCounter.Count()) +} - b = NewBits(10) +func TestBitsLostCounterIssue1(t *testing.T) { + l := test.NewLogger() + b := NewBits(10) b.lostCounter.Clear() b.dupeCounter.Clear() b.outOfWindowCounter.Clear() @@ -232,6 +235,7 @@ func TestBitsLostCounter(t *testing.T) { assert.True(t, b.Update(l, 11)) assert.True(t, b.Update(l, 14)) + // Issue seems to be here, we reset missing packet 8 to false here and don't increment the lost counter assert.True(t, b.Update(l, 19)) assert.True(t, b.Update(l, 12)) assert.True(t, b.Update(l, 13)) @@ -242,7 +246,8 @@ func TestBitsLostCounter(t *testing.T) { assert.True(t, b.Update(l, 20)) assert.True(t, b.Update(l, 21)) - assert.Equal(t, int64(0), b.lostCounter.Count()) + // We missed packet 8 above + assert.Equal(t, int64(1), b.lostCounter.Count()) assert.Equal(t, int64(0), b.dupeCounter.Count()) assert.Equal(t, int64(0), b.outOfWindowCounter.Count()) }