8 Commits

Include renames

Author	SHA1	Message	Date
Nate Brown	357b129749	Bind sshd, dns and stats listeners in the reload so a bind failure fails it	2026-10-19 09:57:21 -05:00
Matt RichardsonandClaude Fable 5.1	8a4bd8b10f	Report ssh command failures to the surface (#1959) ... Report ssh command failures to the surface (#1959) The ssh debug commands told the user when something went wrong but never told the surface that ran them, so `ssh host cmd` always exited 0 and a few failures were not reported at all. A failed command now returns its error, a failure the user has already heard about is a commands.Failure, and the ssh exec path exits 1 for either. The command bodies also lose their ssh prefixes and the duplication they carried over from ssh.go; both goldens pin that nothing else changed. - Dispatch returns the callback's error, or shlex's; the ssh session logs it at debug, and not at all for a Failure the user already saw - commands.Fail writes a message and returns it as a Failure in one step; an unknown command, `help` for a command that is not there, a failed reload and an unbalanced quote are failures - ssh exec exit-status is 1 for a command, flag or failure error, 0 otherwise; the e2e golden records the exit status for every case - Clone rebinds help to the copy, so an ssh session's help lists logout and `help logout` and `logout -h` answer; sshd.LogoutCommand is the session's logout, exported for tests - "did not understand" names the first word only, the one looked up; DispatchArgs takes just the tokens - log-format writes its refusal to the user, as log-level does - print-relays emits the relay error as a string and omits the key when there is none, where it printed {} or "Error":null - list-hostmap and list-lighthouse-addrmap -json return the encode error; print-cert reports a certificate that will not marshal - a flags type that is not the one registered is an internal error, not a silent success - command functions and flag types are <name>Command and <name>Flags; parseVpnAddr and listHostMapFlagSet replace the repeated parse block and flag set; close-tunnel sends through sendCloseTunnel Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>	2026-10-19 10:48:26 -04:00
Matt RichardsonandClaude Fable 5.1	b426843f88	Extract the ssh debug commands into a transport neutral commands package (#1958) ... Migrate commands from ssh into a transport neutral package - add golden tests validating that output remains unchanged - move commands to commands.go Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>	2026-10-19 10:25:28 -04:00
John Maguire	49207da077	Remove the ssh debug profiling commands (#1965) ... We plan to move this functionality into the debug socket.	2026-10-16 15:47:56 -04:00
Nate Brown	a203d044bb	Fail the reload when a config entry is skipped with a warning (#1952)	2026-10-15 23:22:47 -05:00
Nate Brown	316bf87780	Don't restart sshd when only sshd.sandbox_dir changes (#1948)	2026-10-15 22:12:12 -05:00
Nate Brown	1a0ac25db0	Report how a config reload went: failures, restarts required, and the keys that need one (#1935)	2026-10-15 15:36:39 -05:00
Nate Brown	5ba7aff4b3	ssh: Only restart sshd on reload when its config or host key changed (#1923)	2026-10-12 16:56:51 -05:00