mirror of
https://github.com/slackhq/nebula.git
synced 2026-11-15 12:36:52 +01:00
Passthrough.Flush hands its whole lane to a new tio.BatchWriter in one WriteBatch call when the queue implements it, and NewSingleQueue exposes WriteBatch when its source does. On darwin, tun.WriteBatch writes up to 64 packets per sendmsg_x on the utun control socket, which is a connected datagram socket, so xnu takes the batched sendit_x path rather than one sendit per message. utun registers no send_list handler, so the kernel still passes each packet to utun on its own: this saves syscalls and fd locking, not per-packet kernel work. Error handling follows what sendmsg_x reports: - A short count with no error (a packet past the send buffer mid-call, or a later send failing with ENOBUFS): the remainder goes out in the next sendmsg_x. - EMSGSIZE: only returned when the first packet is too large, before the kernel takes any, so that packet alone goes through Write, which reports it, and the rest are batched again. - ENOSYS, EPERM, EOPNOTSUPP: sendmsg_x is private API, so WriteBatch logs once and falls back to writev per packet for good. - Anything else: sendmsg_x returns the error without the count it took, so the call is reported rather than retried, which could deliver packets twice. One loss mode has no userspace fix. sendit_x counts each packet as sent once it is copied into an mbuf; if a later allocation fails, it frees the copied prefix unsent, returns its length, and sendmsg_x drops the ENOBUFS because the count is nonzero. That looks exactly like a real short count, so under mbuf exhaustion WriteBatch silently drops packets that writev would have delivered. The iOS tun path (tun_ios.go) is unchanged. Inside a macOS Network Extension, download goes from 640 to 832 Mbps against the recvmsg_x change alone in three paired rounds, at 15% less CPU per Mbps; the likely cause is that its utun charges more per write than a raw one. Raw dnclient already runs download near line rate, and there the CPU difference is within noise. TestTunWriteBatch* round-trip through a connected AF_UNIX datagram socketpair, which takes sendmsg_x the same way, over both the batched and the fallback path: order, AF prefixes, skipped invalid packets, and an oversize packet mid-call and first-in-call. Dropping Namelen from msghdrX fails them. Mutation testing with gremlins leaves only equivalent survivors in WriteBatch, plus which error is reported first when several fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
154 lines
4.7 KiB
Go
154 lines
4.7 KiB
Go
//go:build !ios && !e2e_testing
|
|
|
|
package overlay
|
|
|
|
import (
|
|
"bytes"
|
|
"os"
|
|
"syscall"
|
|
"testing"
|
|
|
|
"github.com/slackhq/nebula/test"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"golang.org/x/sys/unix"
|
|
)
|
|
|
|
// newSocketpairTun returns a tun writing to one end of a connected AF_UNIX datagram socketpair, which
|
|
// takes sendmsg_x the way a utun control socket does, and the other end's fd for reading back.
|
|
// sndbuf is the writer's send buffer, which caps the largest datagram it accepts.
|
|
func newSocketpairTun(t *testing.T, sndbuf int) (*tun, int) {
|
|
t.Helper()
|
|
fds, err := unix.Socketpair(unix.AF_UNIX, unix.SOCK_DGRAM, 0)
|
|
require.NoError(t, err)
|
|
require.NoError(t, unix.SetsockoptInt(fds[0], unix.SOL_SOCKET, unix.SO_SNDBUF, sndbuf))
|
|
require.NoError(t, unix.SetsockoptInt(fds[1], unix.SOL_SOCKET, unix.SO_RCVBUF, 1<<20))
|
|
// A dropped datagram fails the read-back instead of hanging it.
|
|
require.NoError(t, unix.SetsockoptTimeval(fds[1], unix.SOL_SOCKET, unix.SO_RCVTIMEO, &unix.Timeval{Sec: 2}))
|
|
require.NoError(t, unix.SetNonblock(fds[0], true))
|
|
f := os.NewFile(uintptr(fds[0]), "socketpair")
|
|
t.Cleanup(func() {
|
|
_ = f.Close()
|
|
_ = unix.Close(fds[1])
|
|
})
|
|
return &tun{f: f, l: test.NewLogger()}, fds[1]
|
|
}
|
|
|
|
// testTunPkt returns packet i of size bytes, alternating IPv4 and IPv6, and the datagram the utun
|
|
// device should receive for it.
|
|
func testTunPkt(i, size int) (pkt, wire []byte) {
|
|
pkt = make([]byte, size)
|
|
pkt[0] = 0x45
|
|
af := byte(syscall.AF_INET)
|
|
if i%2 == 1 {
|
|
pkt[0] = 0x60
|
|
af = syscall.AF_INET6
|
|
}
|
|
pkt[1] = byte(i)
|
|
pkt[2] = byte(i >> 8)
|
|
return pkt, append([]byte{0, 0, 0, af}, pkt...)
|
|
}
|
|
|
|
// readTunBack asserts r receives exactly want, in order.
|
|
func readTunBack(t *testing.T, r int, want [][]byte) {
|
|
t.Helper()
|
|
buf := make([]byte, 4096)
|
|
for i, w := range want {
|
|
n, _, err := unix.Recvfrom(r, buf, 0)
|
|
require.NoError(t, err, "datagram %d", i)
|
|
if !bytes.Equal(w, buf[:n]) {
|
|
t.Fatalf("datagram %d: got % x, want % x", i, buf[:n], w)
|
|
}
|
|
}
|
|
_, _, err := unix.Recvfrom(r, buf, unix.MSG_DONTWAIT)
|
|
assert.ErrorIs(t, err, unix.EAGAIN, "extra datagrams delivered")
|
|
}
|
|
|
|
// forEachTunWritePath runs fn once over sendmsg_x and once over the per-packet writev fallback.
|
|
func forEachTunWritePath(t *testing.T, fn func(t *testing.T, fallback bool)) {
|
|
for _, fallback := range []bool{false, true} {
|
|
name := "sendmsg_x"
|
|
if fallback {
|
|
name = "writev"
|
|
}
|
|
t.Run(name, func(t *testing.T) { fn(t, fallback) })
|
|
}
|
|
}
|
|
|
|
// TestTunWriteBatch pins that WriteBatch delivers every packet whole, in order and behind the right
|
|
// utun AF prefix, across several sendmsg_x calls, and returns nil.
|
|
func TestTunWriteBatch(t *testing.T) {
|
|
forEachTunWritePath(t, func(t *testing.T, fallback bool) {
|
|
tn, r := newSocketpairTun(t, 1<<20)
|
|
tn.noSendmsgX.Store(fallback)
|
|
|
|
var pkts, want [][]byte
|
|
for i := range 3*tunWriteBatch + 5 {
|
|
p, w := testTunPkt(i, 60+i)
|
|
pkts = append(pkts, p)
|
|
want = append(want, w)
|
|
}
|
|
require.NoError(t, tn.WriteBatch(pkts))
|
|
assert.Equal(t, fallback, tn.noSendmsgX.Load())
|
|
readTunBack(t, r, want)
|
|
})
|
|
}
|
|
|
|
// TestTunWriteBatchSkipsInvalid pins that an empty packet or one with no IP version is skipped
|
|
// without shifting the packets after it, and that the first such error is the one reported.
|
|
func TestTunWriteBatchSkipsInvalid(t *testing.T) {
|
|
forEachTunWritePath(t, func(t *testing.T, fallback bool) {
|
|
tn, r := newSocketpairTun(t, 1<<20)
|
|
tn.noSendmsgX.Store(fallback)
|
|
|
|
var pkts, want [][]byte
|
|
for i := range 20 {
|
|
p, w := testTunPkt(i, 60)
|
|
pkts = append(pkts, p)
|
|
want = append(want, w)
|
|
}
|
|
pkts = append(pkts[:10], append([][]byte{{0x10, 1, 2}, {}}, pkts[10:]...)...)
|
|
|
|
err := tn.WriteBatch(pkts)
|
|
assert.ErrorContains(t, err, "IP version")
|
|
readTunBack(t, r, want)
|
|
})
|
|
}
|
|
|
|
// TestTunWriteBatchOversize pins that a packet larger than the socket's send buffer drops only
|
|
// itself and is reported, whether sendmsg_x reaches it mid-call (a short count) or first (EMSGSIZE
|
|
// for the whole call). The send buffer is 1024 bytes and the oversize packet 2000.
|
|
func TestTunWriteBatchOversize(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
name string
|
|
at int
|
|
}{
|
|
{"mid-call", tunWriteBatch + 6},
|
|
{"first-in-call", tunWriteBatch},
|
|
} {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
forEachTunWritePath(t, func(t *testing.T, fallback bool) {
|
|
tn, r := newSocketpairTun(t, 1024)
|
|
tn.noSendmsgX.Store(fallback)
|
|
|
|
var pkts, want [][]byte
|
|
for i := range 2*tunWriteBatch + 10 {
|
|
size := 100
|
|
if i == tc.at {
|
|
size = 2000
|
|
}
|
|
p, w := testTunPkt(i, size)
|
|
pkts = append(pkts, p)
|
|
if i != tc.at {
|
|
want = append(want, w)
|
|
}
|
|
}
|
|
err := tn.WriteBatch(pkts)
|
|
assert.ErrorIs(t, err, unix.EMSGSIZE)
|
|
assert.Equal(t, fallback, tn.noSendmsgX.Load())
|
|
readTunBack(t, r, want)
|
|
})
|
|
})
|
|
}
|
|
}
|