mirror of
https://github.com/slackhq/nebula.git
synced 2026-11-15 07:36:52 +01:00
smoke-extra / freebsd-amd64 (push) Failing after 14s
smoke-extra / linux-amd64-ipv6disable (push) Failing after 13s
smoke-extra / netbsd-amd64 (push) Failing after 14s
smoke-extra / openbsd-amd64 (push) Failing after 15s
smoke-extra / linux-386 (push) Failing after 14s
smoke / Run multi node smoke test (push) Failing after 1m46s
Build and test / Static checks (push) Successful in 2m38s
Build and test / Test linux (push) Failing after 1m12s
Build and test / Test linux-pkcs11 (push) Failing after 2m6s
Build and test / Test linux-boringcrypto (push) Failing after 3m0s
Build and test / Test linux-fips140 (push) Failing after 2m56s
Build and test / Cross-build linux-arm (push) Successful in 3m10s
Build and test / Cross-build linux-mips (push) Successful in 3m55s
Build and test / Cross-build linux-other (push) Successful in 3m15s
Build and test / Cross-build windows (push) Successful in 1m5s
Build and test / Cross-build freebsd (push) Successful in 1m37s
Build and test / Cross-build netbsd (push) Successful in 1m36s
Build and test / Cross-build openbsd (push) Successful in 1m35s
Build and test / Cross-build mobile (push) Successful in 3m32s
smoke-extra / Run windows smoke test (push) Canceled after 0s
smoke / Run self traffic smoke test on macOS (push) Canceled after 0s
Build and test / Test macos (push) Canceled after 0s
Build and test / Test windows (push) Canceled after 0s
Build and test / CI status (push) Canceled after 0s
Report ssh command failures to the surface (#1959) The ssh debug commands told the user when something went wrong but never told the surface that ran them, so `ssh host cmd` always exited 0 and a few failures were not reported at all. A failed command now returns its error, a failure the user has already heard about is a commands.Failure, and the ssh exec path exits 1 for either. The command bodies also lose their ssh prefixes and the duplication they carried over from ssh.go; both goldens pin that nothing else changed. - Dispatch returns the callback's error, or shlex's; the ssh session logs it at debug, and not at all for a Failure the user already saw - commands.Fail writes a message and returns it as a Failure in one step; an unknown command, `help` for a command that is not there, a failed reload and an unbalanced quote are failures - ssh exec exit-status is 1 for a command, flag or failure error, 0 otherwise; the e2e golden records the exit status for every case - Clone rebinds help to the copy, so an ssh session's help lists logout and `help logout` and `logout -h` answer; sshd.LogoutCommand is the session's logout, exported for tests - "did not understand" names the first word only, the one looked up; DispatchArgs takes just the tokens - log-format writes its refusal to the user, as log-level does - print-relays emits the relay error as a string and omits the key when there is none, where it printed {} or "Error":null - list-hostmap and list-lighthouse-addrmap -json return the encode error; print-cert reports a certificate that will not marshal - a flags type that is not the one registered is an internal error, not a silent success - command functions and flag types are <name>Command and <name>Flags; parseVpnAddr and listHostMapFlagSet replace the repeated parse block and flag set; close-tunnel sends through sendCloseTunnel Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
169 lines
3.9 KiB
Go
169 lines
3.9 KiB
Go
package sshd
|
|
|
|
import (
|
|
"errors"
|
|
"log/slog"
|
|
"strings"
|
|
|
|
"github.com/slackhq/nebula/commands"
|
|
"golang.org/x/crypto/ssh"
|
|
"golang.org/x/term"
|
|
)
|
|
|
|
type session struct {
|
|
l *slog.Logger
|
|
c *ssh.ServerConn
|
|
term *term.Terminal
|
|
commands *commands.Registry
|
|
cancel func()
|
|
}
|
|
|
|
func NewSession(reg *commands.Registry, conn *ssh.ServerConn, chans <-chan ssh.NewChannel, cancel func(), l *slog.Logger) *session {
|
|
s := &session{
|
|
commands: reg.Clone(),
|
|
l: l,
|
|
c: conn,
|
|
cancel: cancel,
|
|
}
|
|
|
|
s.commands.Register(LogoutCommand(s.Close))
|
|
|
|
go s.handleChannels(chans)
|
|
return s
|
|
}
|
|
|
|
// LogoutCommand is the logout command a session registers on its clone of the registry,
|
|
// with end as what it does. Exported so a test can serve what a session serves.
|
|
func LogoutCommand(end func()) *commands.Command {
|
|
return &commands.Command{
|
|
Name: commands.Logout,
|
|
ShortDescription: "Ends the current session",
|
|
Callback: func(fs any, a []string, w commands.StringWriter) error {
|
|
end()
|
|
return nil
|
|
},
|
|
}
|
|
}
|
|
|
|
func (s *session) handleChannels(chans <-chan ssh.NewChannel) {
|
|
defer s.Close()
|
|
for newChannel := range chans {
|
|
if newChannel.ChannelType() != "session" {
|
|
s.l.Error("unknown channel type", "sshChannelType", newChannel.ChannelType())
|
|
newChannel.Reject(ssh.UnknownChannelType, "unknown channel type")
|
|
continue
|
|
}
|
|
|
|
channel, requests, err := newChannel.Accept()
|
|
if err != nil {
|
|
s.l.Warn("could not accept channel", "error", err)
|
|
continue
|
|
}
|
|
|
|
go s.handleRequests(requests, channel)
|
|
}
|
|
}
|
|
|
|
func (s *session) handleRequests(in <-chan *ssh.Request, channel ssh.Channel) {
|
|
for req := range in {
|
|
var err error
|
|
switch req.Type {
|
|
case "shell":
|
|
if s.term == nil {
|
|
s.term = s.createTerm(channel)
|
|
err = req.Reply(true, nil)
|
|
} else {
|
|
err = req.Reply(false, nil)
|
|
}
|
|
|
|
case "pty-req":
|
|
err = req.Reply(true, nil)
|
|
|
|
case "window-change":
|
|
err = req.Reply(true, nil)
|
|
|
|
case "exec":
|
|
var payload = struct{ Value string }{}
|
|
cErr := ssh.Unmarshal(req.Payload, &payload)
|
|
if cErr != nil {
|
|
req.Reply(false, nil)
|
|
return
|
|
}
|
|
|
|
req.Reply(true, nil)
|
|
err := s.dispatchCommand(payload.Value, commands.NewStringWriter(channel))
|
|
|
|
// A command that failed exits 1, so `ssh host cmd` callers can tell.
|
|
status := struct{ Status uint32 }{uint32(0)}
|
|
if err != nil {
|
|
status.Status = 1
|
|
}
|
|
channel.SendRequest("exit-status", false, ssh.Marshal(status))
|
|
channel.Close()
|
|
return
|
|
|
|
default:
|
|
s.l.Debug("Rejected unknown request", "sshRequest", req.Type)
|
|
err = req.Reply(false, nil)
|
|
}
|
|
|
|
if err != nil {
|
|
s.l.Info("Error handling ssh session requests", "error", err)
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *session) createTerm(channel ssh.Channel) *term.Terminal {
|
|
term := term.NewTerminal(channel, s.c.User()+"@nebula > ")
|
|
term.AutoCompleteCallback = func(line string, pos int, key rune) (newLine string, newPos int, ok bool) {
|
|
// key 9 is tab
|
|
if key == 9 {
|
|
cmds := s.commands.Match(line)
|
|
if len(cmds) == 1 {
|
|
return cmds[0] + " ", len(cmds[0]) + 1, true
|
|
}
|
|
|
|
term.Write([]byte(strings.Join(cmds, "\n") + "\n\n"))
|
|
}
|
|
|
|
return "", 0, false
|
|
}
|
|
|
|
go s.handleInput()
|
|
return term
|
|
}
|
|
|
|
func (s *session) handleInput() {
|
|
w := commands.NewStringWriter(s.term)
|
|
for {
|
|
line, err := s.term.ReadLine()
|
|
if err != nil {
|
|
break
|
|
}
|
|
|
|
s.dispatchCommand(line, w)
|
|
}
|
|
}
|
|
|
|
// dispatchCommand runs line and returns the command's error, which it has logged unless
|
|
// the command already told the user everything: the log line is for the operator reading
|
|
// the daemon's log, who learns nothing from a failure the user caused.
|
|
func (s *session) dispatchCommand(line string, w commands.StringWriter) error {
|
|
err := s.commands.Dispatch(line, w)
|
|
if err == nil {
|
|
return nil
|
|
}
|
|
|
|
var f *commands.Failure
|
|
if !errors.As(err, &f) {
|
|
s.l.Debug("Command returned an error", "line", line, "error", err)
|
|
}
|
|
return err
|
|
}
|
|
|
|
func (s *session) Close() {
|
|
s.c.Close()
|
|
s.cancel()
|
|
}
|