15 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Caleb Jasik	02d8bcac68	Remove lighthouse goroutine leaks in lighthouse_test.go (#1589) ... Using <https://go.dev/doc/go1.26#goroutineleak-profiles> + Claude, I was able to run nebula's unit tests and e2e tests with the leak detector enabled. Added a TestMain that queries pprof to see if there are any reported goroutine leaks. I'd love to get some form of this in CI whenever go 1.26 comes out, though I'd also like to prove this is properly useful past the just five detections it got here. <details> <summary>TestMain</summary> ```go package nebula import ( "fmt" "os" "runtime/pprof" "strings" "testing" ) // TestMain runs after all tests and checks for goroutine leaks func TestMain(m *testing.M) { // Run all tests exitCode := m.Run() // Check for goroutine leaks after all tests complete prof := pprof.Lookup("goroutineleak") if prof != nil { var sb strings.Builder if err := prof.WriteTo(&sb, 2); err != nil { fmt.Fprintf(os.Stderr, "Failed to write goroutineleak profile: %v\n", err) os.Exit(1) } content := sb.String() leakedCount := strings.Count(content, "(leaked)") if leakedCount > 0 { fmt.Fprintf(os.Stderr, "\n=== GOROUTINE LEAK DETECTED ===\n") fmt.Fprintf(os.Stderr, "Found %d leaked goroutine(s) in package nebula\n\n", leakedCount) goros := strings.Split(content, "\n\n") for _, goro := range goros { if strings.Contains(goro, "(leaked)") { fmt.Fprintln(os.Stderr, goro) fmt.Fprintln(os.Stderr) } } os.Exit(1) } else { fmt.Println("✓ No goroutine leaks detected in package nebula") } } os.Exit(exitCode) } ``` </details> Also had to install go1.26rc2 and update the makefile to use that go binary + set ex: ```makefile test-goroutineleak: GOEXPERIMENT=goroutineleakprofile go1.26rc2 test -v ./... ```	2026-01-27 23:44:43 -06:00
Caleb Jasik	4444ed166a	Add certVersion field to logs when logging the cert name in handshakes (#1359)	2025-03-25 16:08:36 -05:00
Caleb Jasik	50473bd2a8	Update example config to listen on :: by default (#1351)	2025-03-12 22:53:16 -05:00
Caleb Jasik	088af8edb2	Enable running testifylint in CI (#1350)	2025-03-10 17:38:14 -05:00
Caleb Jasik	612637f529	Fix testifylint lint errors (#1321) ... * Fix bool-compare * Fix empty * Fix encoded-compare * Fix error-is-as * Fix error-nil * Fix expected-actual * Fix len	2025-03-10 10:18:34 -04:00
Caleb Jasik	f7540ad355	Remove commented out metadata.go (#1320)	2025-03-07 14:37:07 -06:00
Caleb Jasik	8109cf2170	Add puncuation to doc comment (#1164) ... * Add puncuation to doc comment * Fix list formatting inside `EncryptDanger` doc comment	2024-06-24 14:50:17 -04:00
Caleb Jasik	8e94eb974e	Add suggested filenames for collected profiles in the ssh commands (#1109)	2024-04-29 15:20:46 -05:00
Caleb Jasik	ed00f5d530	Remove unused config code (last edited 4yrs ago) (#938)	2023-07-31 15:59:20 -05:00
Caleb Jasik	5da79e2a4c	Run make vet in CI (#693)	2023-03-13 15:35:12 -04:00
Caleb Jasik	f0ac61c1f0	Add nebula.plist based on the homebrew nebula LaunchDaemon plist (#762)	2023-03-13 13:16:46 -05:00
Caleb Jasik	469ae78748	Add homebrew install method to readme (#630)	2023-02-13 14:42:58 -06:00
Caleb Jasik	12dbbd3dd3	Fix typos found by https://github.com/crate-ci/typos (#735)	2022-12-19 11:28:27 -06:00
Caleb Jasik	527f953c2c	Remove x509 config loading code (#685)	2022-06-23 10:27:34 -05:00
Caleb Jasik	730a5c4a23	Update link to nebula docs (#655)	2022-03-18 11:15:16 -04:00