mirror of
https://github.com/slackhq/nebula.git
synced 2026-08-15 23:06:58 +02:00
JackDoan
7ee5e29758
- multi_coalesce/batch: the ordering contract now states what Flush actually guarantees -- per-flow DATA order -- and names the two shapes later data may legally overtake (pure ACKs by design, and unparseable in-flow shapes as an accepted tradeoff). - validVnetHdr claimed DATA_VALID makes the stack skip L4 checksum verification; the tun write path ignores that bit entirely. What the header buys is the absence of NEEDS_CSUM. - tun_darwin Write said "only valid for single threaded use"; it is concurrency-safe and concurrent callers exist. - udp_coalesce eviction comment said "Seal it" but never sets sealed. - recordCapability: note the gauges are process-global while the state is per-socket (last writer wins). - drop a stale tunReadBufSize reference. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014ugV2edVqoz3tBvq9J6yWp
32 lines
1.5 KiB
Go
32 lines
1.5 KiB
Go
package batch
|
|
|
|
import "net/netip"
|
|
|
|
type RxBatcher interface {
|
|
// Commit commits pkt to be flushed by the batch. The caller must keep pkt valid until the next Flush, and not re-use it.
|
|
Commit(pkt []byte) error
|
|
// Flush emits every queued packet. The guarantee is per-flow DATA order:
|
|
// a flow's payload-bearing packets are never reordered relative to each
|
|
// other. Cross-flow and cross-lane order is not preserved, and two shapes
|
|
// may legally be overtaken by later same-flow data: pure ACKs (by design,
|
|
// stale ACKs are ignored) and unparseable shapes such as fragments (an
|
|
// accepted tradeoff; see MultiCoalescer).
|
|
// Returns the first error observed; keeps draining so one bad packet doesn't hold up the rest.
|
|
// After Flush returns, committed payload slices may be recycled.
|
|
Flush() error
|
|
}
|
|
|
|
type TxBatcher interface {
|
|
// Reserve creates a pkt to borrow
|
|
Reserve(sz int) []byte
|
|
// Commit borrows pkt and records its destination plus the 2-bit
|
|
// IP-level ECN codepoint to set on the outer (carrier) header. The
|
|
// caller must keep pkt valid until the next Flush. Pass 0 (Not-ECT)
|
|
// to leave the outer ECN field unset.
|
|
Commit(pkt []byte, dst netip.AddrPort, outerECN byte)
|
|
// Flush emits every queued packet via the underlying batch writer in arrival order and reports how many were
|
|
// actually written. A short count means some destinations were undeliverable, not that the batch failed.
|
|
// After Flush returns, borrowed payload slices may be recycled.
|
|
Flush() (int, error)
|
|
}
|